On Wed, Mar 14, 2018 at 5:24 PM, Gary R Hook <gary.h...@amd.com> wrote: > On 03/13/2018 03:23 PM, Andy Shevchenko wrote:
>>>>> +#include <linux/pci.h> >>>>> +#include <linux/iommu.h> >>>>> +#include <linux/debugfs.h> >>>> Keep in order? >>> What order would that be? These few needed files are listed in the same >>> order as which they appear in amd_iommu.c. I'm gonna need a preference >>> spelled out, please (and a rationale, so I may better understand). >> To increase readability and avoid potential header duplication (here >> is can bus protocol implementation where the problem exists for real, >> even in new code!) > With all due respect, I don't find that you clearly answered my question. Alphabetical order I meant. > I > will hazard a guess that you mean to -alphabetize- them? Which I am happy to > do, and will do so in the next version. Yes, please. -- With Best Regards, Andy Shevchenko
