On Tue, Apr 03, 2018 at 07:03:46PM +0200, Andreas Färber wrote: > Hi Mani, > > Am 03.04.2018 um 19:00 schrieb Manivannan Sadhasivam: > > On Sat, Mar 31, 2018 at 12:16:49AM +0300, Andy Shevchenko wrote: > >> On Wed, Mar 28, 2018 at 8:46 PM, Manivannan Sadhasivam > >> <[email protected]> wrote: > >>> +static const struct pinconf_ops owl_pinconf_ops = { > >>> + .is_generic = true, > >>> + .pin_config_get = owl_pin_config_get, > >>> + .pin_config_set = owl_pin_config_set, > >>> + .pin_config_group_get = owl_group_config_get, > >>> + .pin_config_group_set = owl_group_config_set > >> > >> It's still good idea to leave comma here... > >> > > > > I'm confused. What is the criteria for removing/keeping comma for last > > member > > of struct? I followed your gpio driver suggestion. > > No comma for list terminator ("{}") because nothing goes after it; comma > whenever it allows adding a new line without touching the old one, i.e. > keeping future diff small. >
Thanks for the clarification Andreas! Keeping the future diff small is the key, understood. Thanks, Mani > Cheers, > Andreas > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg)
