From: Arnaldo Carvalho de Melo <>

Now that we can have extra title lines we should use ui_browser->rows
and not ->height when drawing lines, as it will use ui_browser__gotorc()
and that will take the extra title lines into account, which was causing
an off by one at the end of the vertical line drawn by
__ui_browser__vline(), fix it.

The visual effect was that the last line, with status messages, was
being overwritten by the vertical line, looking like:

Press 'h' for help on│key bindings

Cc: Adrian Hunter <>
Cc: Andi Kleen <>
Cc: David Ahern <>
Cc: Jin Yao <>
Cc: Jiri Olsa <>
Cc: Namhyung Kim <>
Cc: Wang Nan <>
Fixes: ef9ff6017e3c ("perf ui browser: Move the extra title lines from the 
hists browser")
Signed-off-by: Arnaldo Carvalho de Melo <>
 tools/perf/ui/browsers/annotate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/ui/browsers/annotate.c 
index 78bcd220f1b6..12c099a87f8b 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -218,7 +218,7 @@ static unsigned int annotate_browser__refresh(struct 
ui_browser *browser)
        ui_browser__set_color(browser, HE_COLORSET_NORMAL);
-       __ui_browser__vline(browser, pcnt_width, 0, browser->height - 1);
+       __ui_browser__vline(browser, pcnt_width, 0, browser->rows - 1);
        return ret;

Reply via email to