Hi Finn,

On Sun, Apr 1, 2018 at 3:41 AM, Finn Thain <fth...@telegraphics.com.au> wrote:
> In the floppy_find() function in swim.c is a call to
> get_disk(swd->unit[drive].disk). The actual parameter to this call
> can be a NULL pointer when drive == swd->floppy_count. This causes
> an oops in get_disk().
> Data read fault at 0x00000198 in Super Data (pc=0x1be5b6)


> Fix the array index bounds check to avoid this.
> Fixes: 8852ecd97488 ("[PATCH] m68k: mac - Add SWIM floppy support")
> Cc: Laurent Vivier <lviv...@redhat.com>
> Cc: Jens Axboe <ax...@kernel.dk>
> Tested-by: Stan Johnson <user...@yahoo.com>
> Signed-off-by: Finn Thain <fth...@telegraphics.com.au>

Reviewed-by: Geert Uytterhoeven <ge...@linux-m68k.org>

Looks like amiflop.c:find_floppy() needs a check, too?



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Reply via email to