On Tue, 10 Apr 2018 21:19:31 +0300 "Michael S. Tsirkin" <m...@redhat.com> wrote:
> > Andrew, were your questions answered? If yes could I bother you for an ack on > this? > Still not very happy that readers are told that "this function may sleep" when it clearly doesn't do so. If we wish to be able to change it to sleep in the future then that should be mentioned. And even put a might_sleep() in there, to catch people who didn't read the comments... Otherwise it looks OK.