On 2018/4/11 23:04, Ulf Hansson wrote:
On 11 April 2018 at 04:46, Jia-Ju Bai <baijiaju1...@gmail.com> wrote:
wbsd_init() is never called in atomic context.

The call chains ending up at wbsd_init() are:
[1] wbsd_init() <- wbsd_probe()
[2] wbsd_init() <- wbsd_pnp_probe()

wbsd_probe() is set as ".probe" in struct platform_driver.
wbsd_pnp_probe() is set as ".probe" in struct pnp_driver.
These functions are not called in atomic context.

Despite never getting called from atomic context, wbsd_init()
calls mdelay() to busily wait.
This is not necessary and can be replaced with usleep_range() to
avoid busy waiting.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com>
The patch is good, however I think you should squash all three in this
series into one. For obvious reasons.

Hello, Ulf.
Thanks for your reply and advice :)
I will follow it in my future patches.

Best wishes,
Jia-Ju Bai

Reply via email to