Hi, * kbuild test robot <[email protected]> [180418 17:48]: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: a27fc14219f2e3c4a46ba9177b04d9b52c875532 > commit: 5d1ebbda0318b1ba55eaa1fae3fd867af17b0774 phy: mapphone-mdm6600: Add > USB PHY driver for MDM6600 on Droid 4 > date: 5 weeks ago > config: x86_64-randconfig-a0-04190121 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 > reproduce: > git checkout 5d1ebbda0318b1ba55eaa1fae3fd867af17b0774 > # save the attached .config to linux build tree > make ARCH=x86_64 > > All warnings (new ones prefixed by >>): > > #'target_mem_ref' not supported by > expression#'drivers/phy/motorola/phy-mapphone-mdm6600.c: In function > 'phy_mdm6600_status': > >> drivers/phy/motorola/phy-mapphone-mdm6600.c:188:16: warning: is used > >> uninitialized in this function [-Wuninitialized] > val |= values[i] << i; > ~~~~~~^~~
Thanks for the report and sorry for the delay in responding. Looks like gpiod_get_array_value_cansleep initializes values. But we do have wrong defines here, see the patch belwo. Not sure if that is enough to fix the warning here though? I'm not seeing the warning here with gcc-7.3.0 binutils-2.30. Regards, Tony 8< --------------------- >From tony Mon Sep 17 00:00:00 2001 From: Tony Lindgren <[email protected]> Date: Wed, 25 Apr 2018 07:47:57 -0700 Subject: [PATCH] phy: mapphone-mdm6600: Fix wrong enum used for status lines Kbuilt test robot reported: drivers/phy/motorola/phy-mapphone-mdm6600.c:188:16: warning: is used uninitialized in this function [-Wuninitialized] val |= values[i] << i; ~~~~~~^~~ Looking at the phy_mdm6600_status() values does get initialized by gpiod_get_array_value_cansleep(), but we are using wrong enum in that function. Let's fix the use, both end up being three though so urgent rush on this one AFAIK. Fixes: 5d1ebbda0318 ("phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4") Reported-by: kbuild test robot <[email protected]> Signed-off-by: Tony Lindgren <[email protected]> --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -178,13 +178,13 @@ static void phy_mdm6600_status(struct work_struct *work) ddata = container_of(work, struct phy_mdm6600, status_work.work); dev = ddata->dev; - error = gpiod_get_array_value_cansleep(PHY_MDM6600_NR_CMD_LINES, + error = gpiod_get_array_value_cansleep(PHY_MDM6600_NR_STATUS_LINES, ddata->status_gpios->desc, values); if (error) return; - for (i = 0; i < PHY_MDM6600_NR_CMD_LINES; i++) { + for (i = 0; i < PHY_MDM6600_NR_STATUS_LINES; i++) { val |= values[i] << i; dev_dbg(ddata->dev, "XXX %s: i: %i values[i]: %i val: %i\n", __func__, i, values[i], val); -- 2.17.0
