On Fri, May 04, 2018 at 10:04:48AM -0700, Florian Fainelli wrote: > On 05/04/2018 06:56 AM, Antoine Tenart wrote: > > SFP connectors can be solder on a board without having any of their pins > > (LOS, i2c...) wired. In such cases the SFP link state cannot be guessed, > > and the overall link status reporting is left to other layers. > > > > In order to achieve this, a new SFP_DEV status is added, named UNKNOWN. > > This mode is set when it is not possible for the SFP code to get the > > link status and as a result the link status is reported to be always UP > > from the SFP point of view. > > Why represent the SFP in Device Tree then? Why not just declare this is > a fixed link which would avoid having to introduce this "unknown" state.
Hi Antoine I agree with Florian here. It LOS was missing, but i2c worked, i could see some value in using SFP, or order to be able to read the EEPROM. But if everything is missing, fixed-link seems a better fit. Andrew