2018-05-05 1:21 GMT+09:00 Kees Cook <[email protected]>: > On Fri, May 4, 2018 at 7:21 AM, Masahiro Yamada > <[email protected]> wrote: >> Hi Kees, >> >> >> 2018-04-13 14:06 GMT+09:00 Masahiro Yamada <[email protected]>: >>> Since commit d677a4d60193 ("Makefile: support flag >>> -fsanitizer-coverage=trace-cmp"), you miss to build the SANCOV >>> plugin under some circumstances. >>> >>> CONFIG_KCOV=y >>> CONFIG_KCOV_ENABLE_COMPARISONS=y >>> Your compiler does not support -fsanitize-coverage=trace-pc >>> Your compiler does not support -fsanitize-coverage=trace-cmp >>> >>> Under this condition, $(CFLAGS_KCOV) is not empty but contains a >>> space, so the following ifeq-conditional is false. >>> >>> ifeq ($(CFLAGS_KCOV),) >>> >>> Then, scripts/Makefile.gcc-plugins misses to add sancov_plugin.so to >>> gcc-plugin-y while the SANCOV plugin is necessary as an alternative >>> means. >>> >>> Fixes: d677a4d60193 ("Makefile: support flag >>> -fsanitizer-coverage=trace-cmp") >>> Signed-off-by: Masahiro Yamada <[email protected]> >>> --- >> >> >> I am planning to queue this up to the fixes branch >> since this is a bug fix. >> >> Do you have any comment on this? > > Looks fine to me; thanks! > > Acked-by: Kees Cook <[email protected]> > > -Kees > >>
Applied to linux-kbuild/fixes. -- Best Regards Masahiro Yamada
