Christoph Hellwig <[email protected]> wrote:
> The other option I though about would be to hide a write callback
> in struct seq_operations, as that way all the existing helpers would
> just work.
That could work too.
> Btw one of the lines above is over 80 chars. By using normal two
> tab indents for the continuations this would become a lot more readable:
>
> struct proc_dir_entry *proc_create_net_data_write(const char *name,
> umode_t mode, struct proc_dir_entry *parent,
> const struct seq_operations *ops, proc_write_t write,
> unsigned int state_size, void *data)
Actually, it's less readable because the first argument isn't left-aligned
with the rest. I'd suggest moving the first argument onto a separate line
also:
struct proc_dir_entry *proc_create_net_data_write(
const char *name, umode_t mode, struct proc_dir_entry *parent,
const struct seq_operations *ops, proc_write_t write,
unsigned int state_size, void *data)
David
