On Mon, May 14, 2018 at 04:58:50PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" <[email protected]> > > The filter file in the ftrace internal events, like in > /sys/kernel/tracing/events/ftrace/function/filter is not attached to any > functionality. Do not create them as they are meaningless. > > In the future, if an ftrace internal event gets filter functionality, then > it will need to create it directly. > > Signed-off-by: Steven Rostedt (VMware) <[email protected]> > --- > kernel/trace/trace_events.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index 5b647904a65b..14ff4ff3caab 100644 > --- a/kernel/trace/trace_events.c > +++ b/kernel/trace/trace_events.c > @@ -2007,16 +2007,18 @@ event_create_dir(struct dentry *parent, struct > trace_event_file *file) > return -1; > } > } > - trace_create_file("filter", 0644, file->dir, file, > - &ftrace_event_filter_fops); > > /* > * Only event directories that can be enabled should have > - * triggers. > + * triggers or filters. > */ > - if (!(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE)) > + if (!(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE)) { > + trace_create_file("filter", 0644, file->dir, file, > + &ftrace_event_filter_fops); > + > trace_create_file("trigger", 0644, file->dir, file, > &event_trigger_fops); > + } > > #ifdef CONFIG_HIST_TRIGGERS > trace_create_file("hist", 0444, file->dir, file,
What about moving the "hist" file as well since it's meaningless without the trigger. Thanks, Namhyung
