On Wed, 16 May 2018 18:10:25 +0900
Namhyung Kim <[email protected]> wrote:
> > /*
> > * Only event directories that can be enabled should have
> > - * triggers.
> > + * triggers or filters.
> > */
> > - if (!(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE))
> > + if (!(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE)) {
> > + trace_create_file("filter", 0644, file->dir, file,
> > + &ftrace_event_filter_fops);
> > +
> > trace_create_file("trigger", 0644, file->dir, file,
> > &event_trigger_fops);
> > + }
> >
> > #ifdef CONFIG_HIST_TRIGGERS
> > trace_create_file("hist", 0444, file->dir, file,
>
> What about moving the "hist" file as well since it's meaningless
> without the trigger.
I thought about doing this too. But when I had to manually create the
trigger file, I'll have to also manually create the hist file. As the
hist file is read only and rather harmless, I figured I'd just leave it
as is. The filter file is a command file and this patch wants to remove
the confusion of writing into the file and having no effect.
-- Steve
