match_string() returns the index of an array for a matching string,
which can be used intead of open coded variant.

Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.v...@intel.com>
Cc: David Airlie <airl...@linux.ie>
Cc: intel-...@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Yisheng Xie <xieyishe...@huawei.com>
---
 drivers/gpu/drm/i915/intel_pipe_crc.c | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.c 
b/drivers/gpu/drm/i915/intel_pipe_crc.c
index 1f5cd57..f6b1335 100644
--- a/drivers/gpu/drm/i915/intel_pipe_crc.c
+++ b/drivers/gpu/drm/i915/intel_pipe_crc.c
@@ -764,13 +764,12 @@ enum intel_pipe_crc_object {
 {
        int i;
 
-       for (i = 0; i < ARRAY_SIZE(pipe_crc_objects); i++)
-               if (!strcmp(buf, pipe_crc_objects[i])) {
-                       *o = i;
-                       return 0;
-               }
+       i = match_string(pipe_crc_objects, ARRAY_SIZE(pipe_crc_objects), buf);
+       if (i < 0)
+               return -EINVAL;
 
-       return -EINVAL;
+       *o = i;
+       return 0;
 }
 
 static int display_crc_ctl_parse_pipe(struct drm_i915_private *dev_priv,
@@ -796,13 +795,12 @@ static int display_crc_ctl_parse_pipe(struct 
drm_i915_private *dev_priv,
                return 0;
        }
 
-       for (i = 0; i < ARRAY_SIZE(pipe_crc_sources); i++)
-               if (!strcmp(buf, pipe_crc_sources[i])) {
-                       *s = i;
-                       return 0;
-               }
+       i = match_string(pipe_crc_sources, ARRAY_SIZE(pipe_crc_sources), buf);
+       if (i < 0)
+               return -EINVAL;
 
-       return -EINVAL;
+       *s = i;
+       return 0;
 }
 
 static int display_crc_ctl_parse(struct drm_i915_private *dev_priv,
-- 
1.7.12.4

Reply via email to