On Wed, May 23, 2018 at 11:11:31AM +0900, Masahiro Yamada wrote: > It is redundant to pass -DNCURSES_WIDECHAR=1 explicitly; when we use > 'pkg-config --cflags', it takes care of appropriate flags. > > Actually, 'pkg-config --cflags' will add -D_GNU_SOURCE, which will > define _XOPEN_SOURCE_EXTENDED, and NCURSES_WIDECHAR=1, anyway. > > I added -D_GNU_SOURCE to follow the suggestion of pkg-config > for cases where pkg-config is not useful. > > Signed-off-by: Masahiro Yamada <[email protected]> > --- > > The v3 (https://patchwork.kernel.org/patch/10417413/) was > reviewed and tested. > > I'd like to squash this into it.
Looks good. Reviewed-off-by: Sam Ravnborg <[email protected]> Sam
