On Mon, May 28, 2018 at 06:12:09AM -0700, Davidlohr Bueso wrote: > > Well, I don't really _want_ them; nor does the ipc code which already > does a WARN_ON() (but that goes away in future patches). What I want > is to get rid of the return path. So I don't really care if we convert > them to WARN or remove them altogether. Would you be happy with the > later?
It has nothing to do with the error return path. Assuming you remove the allocation failure path, then this error path can never trigger for *your* use-case. IOW you can either just ignore the return value for ipc or just do the WARN_ON in your code. Cheers, -- Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
