On Wed, May 30, 2018 at 11:36:26AM +0000, Rohit Khatri wrote:
> From: Rohit Khatri 
> <[email protected]><mailto:[email protected]>
> Subject: [PATCH 4.17-rc7 1/1] lib/kobject_uevent : fix uevent environment 
> variable update with kobject event

What are these lines doing in the email body?

> Function kobject_uevent_env is unable to update uevent variables as sequence 
> of code is overwriting user added environment variable(s).
> For example, if there is a variable named "KEY" in uevent environment with 
> initial value of 0 and if update on any event using  kobject_uevent_env 
> function, value of variable would be 0 only or whatever is initialized 
> because after loading user called variable, function is again reloading same 
> variables.

Please always wrap your changelog lines at the proper column, like your
editor asked you to when you wrote the patch.

> Signed-off-by: Rohit Khatri 
> <[email protected]><mailto:[email protected]>
> Cc: [email protected]<mailto:[email protected]>

What is with the crazy mailto: stuff?

Please fix up and we can review the patch...

Also, does this "fix" a patch that is already in the tree?  If so,
please use the Fixes: tag to specify what commit it fixes.

thanks,

greg k-h

Reply via email to