On Tue, Jun 5, 2018 at 7:16 PM, Dmitry Torokhov <[email protected]> wrote: > Let's make input_report_slot_state() return boolean representing whether > the contact is active or not. This will allow writing code like: > > if (input_mt_report_slot_state(input, obj->mt_tool, > obj->type != RMI_2D_OBJECT_NONE) { > > input_event(sensor->input, EV_ABS, ABS_MT_POSITION_X, obj->x); > input_event(sensor->input, EV_ABS, ABS_MT_POSITION_Y, obj->y); > ... > } > > instead of: > > input_mt_report_slot_state(input, obj->mt_tool, > obj->type != RMI_2D_OBJECT_NONE); > if (obj->type != RMI_2D_OBJECT_NONE) { > input_event(sensor->input, EV_ABS, ABS_MT_POSITION_X, obj->x); > input_event(sensor->input, EV_ABS, ABS_MT_POSITION_Y, obj->y); > ... > } > > Signed-off-by: Dmitry Torokhov <[email protected]> > ---
Looks good to me as well. In case you still need it: Acked-by: Benjamin Tissoires <[email protected]> Cheers, Benjamin
