Hello Morimoto-san, > -----Original Message----- > From: Kuninori Morimoto <[email protected]> > Sent: Monday, June 11, 2018 2:27 PM > To: Suzuki, Katsuhiro <[email protected]> > Cc: Mark Brown <[email protected]>; [email protected]; Masami Hiramatsu > <[email protected]>; Jassi Brar <[email protected]>; > [email protected]; [email protected] > Subject: Re: [PATCH v2 2/3] ASoC: simple-card: move hp and mic detection to soc_card > probe > > > Hi Katsuhiro-san > > > This patch moves headphone and microphone detection to probe() of > > snd_soc_card from init() of snd_soc_dai_link. This is because init() > > is called (and an input device /dev/input/eventX is created too) > > twice or above if simple card has two or more DAI links. > > > > Signed-off-by: Katsuhiro Suzuki <[email protected]> > > or above ? >
It seems if simple card has multiple DAI links, it creates multiple input devices. For example simple card has 3-links, 3 input devices /dev/input/event0, event1, event2 are created. Is it correct? > > - ret = asoc_simple_card_init_hp(rtd->card, &priv->hp_jack, PREFIX); > > - if (ret < 0) > > - return ret; > > - > > - ret = asoc_simple_card_init_mic(rtd->card, &priv->mic_jack, PREFIX); > > - if (ret < 0) > > - return ret; > (snip) > > + ret = asoc_simple_card_init_hp(card, &priv->hp_jack, NULL); > > + if (ret < 0) > > + return ret; > > + > > + ret = asoc_simple_card_init_mic(card, &priv->mic_jack, NULL); > > + if (ret < 0) > > + return ret; > > I think we want to keep "PREFIX" ? > Oops... Thank you. I'll fix it. Regards, -- Katsuhiro Suzuki > > Best regards > --- > Kuninori Morimoto
