On Fri, Jun 29, 2018 at 8:51 PM, Kees Cook <[email protected]> wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > switches to using a pre-allocated scratch register space, set up with > all other other allocations. > > [1] > https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qpxydaacu1rq...@mail.gmail.com > > Cc: Linus Walleij <[email protected]> > Cc: Dan Williams <[email protected]> > Cc: Vinod Koul <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Kees Cook <[email protected]>
I looked too long at this one, in short: - Your change looks correct to me - It could be done better in many ways, all of which would involve cleaning up some of the existing code in the process - Nobody uses this driver in practice, as the hardware platform was a dead end Reviewed-by: Arnd Bergmann <[email protected]>
