On 11/07/18 12:17, Peter De Schrijver wrote: > On Wed, Jul 11, 2018 at 09:42:20AM +0100, Jon Hunter wrote: >> >> On 11/07/18 09:00, Peter De Schrijver wrote: >>> On Tue, Jul 10, 2018 at 05:17:05PM +0100, Jon Hunter wrote: >>>> >>>> On 09/07/18 17:38, Aapo Vienamo wrote: >>>>> From: Peter De Schrijver <pdeschrij...@nvidia.com> >>>>> >>>>> Move this to a separate file so it can be used to calculate the sdmmc >>>>> clock dividers. >>>> >>>> Sorry for not commenting sooner, but what is the motivation for moving >>>> this to its own file? I don't see why we need to do this in order to use >>>> elsewhere. Furthermore, the original file is quite aptly named >>>> 'clk-divider.c' >>>> and now we have a div71.c which seems quite specific. >>> >>> How else would you do it? >> >> Keep it in the same file? >> > > That seems odd. clk-divider.c is meant to implement a clock type, not > utility functions we happen to need in several types.
I see, then why not have a clk-utils.c for stuff like this. I am painting the bikeshed here, but div71.c seems very specific and I still don't understand the 7.1 bit. Cheers Jon -- nvpublic
