On (07/11/18 23:09), Steven Rostedt wrote:
> > On (07/11/18 15:17), Steven Rostedt wrote:
> > > +bool ignore_console_lock_warning __read_mostly;
> > > +EXPORT_SYMBOL(ignore_console_lock_warning);
> >
> > OK. So, to recap,
> > We made is_console_locked() EXPORT_SYMBOL recently [it's still in
> > linux-next],
> > so people could use WARN_CONSOLE_UNLOCKED in more places; this made other
> > people unhappy, so now we add another EXPORT_SYMBOL to the picture, which
> > will
> > disable those newly added WARN_CONSOLE_UNLOCKED and make other people happy
> > again.
>
> Note, it only made people that added a module parameter that disables
> grabbing the console lock in the first place for debugging purposes
> only. The added WARN_CONSOLE_UNLOCKED() are good. Nobody complaining
> that they exist. They are complaining that it breaks one of their
> debugging work flows, and need to disable it when they are doing so.
True, but at the same time nobody complained that we didn't have those
extra WARN_CONSOLE_UNLOCKED()-s. Just saying. Over all I agree that there
is probably some value in those extra WARN-s.
> I could add a comment explaining why it exists. Something like:
>
> /*
> * Set this is you need to quiet WARN_CONSOLE_UNLOCKED() for debugging
> * purposes.
> */
s/is you/if you/
Suggested-by: one-of-those-commit...@youknowwhoyouare.org ;)
-ss
