On Thu, Jul 12, 2018 at 01:17:26PM +0200, Dominique Martinet wrote: > Matthew Wilcox wrote on Wed, Jul 11, 2018: > > diff --git a/net/9p/client.c b/net/9p/client.c > > index 389a2904b7b3..b89c7298267c 100644 > > --- a/net/9p/client.c > > +++ b/net/9p/client.c > > memset(&fid->qid, 0, sizeof(struct p9_qid)); > > Ah, I had missed that you didn't update this memset as you said in reply > to comment on v1.
Rather than update the memset, I ... > Could you resend just this patch and either initialize fid->fid or use > kzalloc for the fid allocation? > > > + fid->fid = 0; Did that instead ;-) If I were going to initialise the entire structure to 0, I'd replace the kmalloc with kzalloc and drop the memset altogether. > If you do resend, alignment here was wrong. I think this warning from checkpatch is complete bullshit. It's really none of checkpatch's business how I choose to align function arguments. That said, if you want it to be aligned some particular way, feel free to adjust the whitespace. I don't care.
