Hi Yixun, thanks for the review 2018-08-03 16:14 GMT+02:00 Yixun Lan <yixun....@gmail.com>: >> +config MESON_CANVAS >> + bool "Amlogic Meson Canvas driver" > shouldn't this a 'tristate'? since you'd make the driver a kernel module..
Yep it should! I well noted your other feedback and v2 will have fixes for them :) .
