Hi, this email is from Rob's (experimental) review bot. I found a couple
of common problems with your patch. Please see below.

On Thu, 16 Aug 2018 18:35:44 +0200, Paul Cercueil wrote:
> The pinctrl-ingenic driver is now handling the GPIO chips directly.
> 
> Signed-off-by: Paul Cercueil <[email protected]>

The preferred subject prefix is "dt-bindings: <binding dir>: ...".

> ---
>  .../devicetree/bindings/gpio/ingenic,gpio.txt      |  46 ---
>  drivers/gpio/Kconfig                               |  11 -
>  drivers/gpio/Makefile                              |   1 -
>  drivers/gpio/gpio-ingenic.c                        | 392 
> ---------------------
>  4 files changed, 450 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/gpio/ingenic,gpio.txt
>  delete mode 100644 drivers/gpio/gpio-ingenic.c
> 

DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.

Reply via email to