> > On Sun, Aug 26, 2018 at 3:51 PM Linus Torvalds <torvalds@linux- > foundation.org> wrote: > > > > So two weeks have passed, and the merge window for 4.19 is over. > > > > > > Anyway, go forth and test, > > > > I am seeing the errors use-after-free errors in mei_cl_write. dmesg as > follows. > Adding Tomas Winkler to the thread. > https://lkml.org/lkml/2018/8/23/83
Thanks for the report, the fix was already sent out a week ago, hope it will make it into 4.19-rc2 Thanks Tomas > [ 12.602912] PM: Adding info for > mei:mei::309dcde8-ccb1-4062-8f78-600115a34327:01 > [ 12.603126] > ================================================================ > == > [ 12.603205] BUG: KASAN: use-after-free in mei_cl_write+0x481/0x860 > [ 12.603248] Read of size 8 at addr ffff880416d3a320 by task kworker/2:1/68 > > [ 12.603311] CPU: 2 PID: 68 Comm: kworker/2:1 Tainted: G W > 4.19.0-rc1 #1 > [ 12.603363] Hardware name: System76, Inc. Wild Dog > Performance/H87-PLUS, BIOS 0705 12/05/2013 > [ 12.603420] Workqueue: events mei_cl_bus_rescan_work > [ 12.603459] Call Trace: > [ 12.603486] dump_stack+0x7c/0xbb > [ 12.603520] print_address_description+0x73/0x280 > [ 12.603560] kasan_report+0x258/0x380 > [ 12.603589] ? mei_cl_write+0x481/0x860 > [ 12.603625] mei_cl_write+0x481/0x860 > [ 12.603664] ? mei_cl_irq_write+0x570/0x570 > [ 12.603699] ? kasan_unpoison_shadow+0x30/0x40 > [ 12.603735] ? kasan_kmalloc+0xa0/0xd0 > [ 12.603770] ? wait_woken+0x140/0x140 > [ 12.603803] ? mei_cl_alloc_cb+0xa9/0xf0 > [ 12.603847] __mei_cl_send+0x371/0x3e0 > [ 12.603888] ? wait_for_completion+0x1d0/0x1d0 > [ 12.603923] ? mei_cldev_driver_unregister+0x40/0x40 > [ 12.603961] ? find_first_zero_bit+0x19/0x70 > [ 12.604014] mei_mkhi_fix+0x12d/0x480 > [ 12.604045] ? worker_thread+0x69/0x690 > [ 12.604075] ? kthread+0x1ae/0x1d0 > [ 12.604103] ? ret_from_fork+0x3a/0x50 > [ 12.604135] ? check_chain_key+0x139/0x1f0 > [ 12.604173] ? mei_wd+0xa0/0xa0 > [ 12.604203] ? mark_lock+0xc7/0x7c0 > [ 12.604234] ? mark_lock+0xc7/0x7c0 > [ 12.604285] mei_cl_bus_dev_fixup+0x196/0x1b0 > [ 12.604322] ? mei_nfc+0x4d0/0x4d0 > [ 12.604354] ? lockdep_hardirqs_on+0x18c/0x280 > [ 12.604400] ? __kasan_slab_free+0x143/0x180 > [ 12.604441] ? mei_cl_bus_rescan_work+0x2f1/0x500 > [ 12.604477] mei_cl_bus_rescan_work+0x2f1/0x500 > [ 12.604527] process_one_work+0x5e5/0xb00 > [ 12.604573] ? wq_pool_ids_show+0x1e0/0x1e0 > [ 12.604628] worker_thread+0x69/0x690 > [ 12.604675] ? process_one_work+0xb00/0xb00 > [ 12.604706] kthread+0x1ae/0x1d0 > [ 12.604734] ? kthread_create_worker_on_cpu+0xc0/0xc0 > [ 12.604776] ret_from_fork+0x3a/0x50 > > [ 12.604845] Allocated by task 68: > [ 12.604872] kasan_kmalloc+0xa0/0xd0 > [ 12.604900] kmem_cache_alloc_trace+0x118/0x250 > [ 12.604933] mei_cl_alloc_cb+0x3b/0xf0 > [ 12.604962] __mei_cl_send+0x312/0x3e0 > [ 12.604991] mei_mkhi_fix+0x12d/0x480 > [ 12.605020] mei_cl_bus_dev_fixup+0x196/0x1b0 > [ 12.605052] mei_cl_bus_rescan_work+0x2f1/0x500 > [ 12.605085] process_one_work+0x5e5/0xb00 > [ 12.605116] worker_thread+0x69/0x690 > [ 12.605144] kthread+0x1ae/0x1d0 > [ 12.605170] ret_from_fork+0x3a/0x50 > > [ 12.605213] Freed by task 104: > [ 12.605238] __kasan_slab_free+0x12e/0x180 > [ 12.605269] kfree+0xd4/0x250 > [ 12.605294] mei_cl_complete+0xc1/0x230 > [ 12.605324] mei_irq_compl_handler+0x95/0xf0 > [ 12.605356] mei_me_irq_thread_handler+0x7e5/0xc90 > [ 12.605391] irq_thread_fn+0x3f/0x80 > [ 12.605418] irq_thread+0x175/0x250 > [ 12.605446] kthread+0x1ae/0x1d0 > [ 12.605472] ret_from_fork+0x3a/0x50 > > [ 12.605515] The buggy address belongs to the object at ffff880416d3a300 > which belongs to the cache kmalloc-96 of size 96 > [ 12.605591] The buggy address is located 32 bytes inside of > 96-byte region [ffff880416d3a300, ffff880416d3a360) > [ 12.605662] The buggy address belongs to the page: > [ 12.605697] page:ffffea00105b4e80 count:1 mapcount:0 > mapping:ffff8800b580f400 index:0x0 > [ 12.605753] flags: 0xa00000000000100(slab) > [ 12.605785] raw: 0a00000000000100 dead000000000100 > dead000000000200 > ffff8800b580f400 > [ 12.605838] raw: 0000000000000000 0000000080200020 00000001ffffffff > 0000000000000000 > [ 12.605888] page dumped because: kasan: bad access detected > > [ 12.605941] Memory state around the buggy address: > [ 12.605976] ffff880416d3a200: fb fb fb fb fb fb fb fb fb fb fb fb > fc fc fc fc > [ 12.606024] ffff880416d3a280: fb fb fb fb fb fb fb fb fb fb fb fb > fc fc fc fc > [ 12.606073] >ffff880416d3a300: fb fb fb fb fb fb fb fb fb fb fb fb > fc fc fc fc > [ 12.606121] ^ > [ 12.606152] ffff880416d3a380: fc fc fc fc fc fc fc fc fc fc fc fc > fc fc fc fc > [ 12.606201] ffff880416d3a400: fc fc fc fc fc fc fc fc fc fc fc fc > fc fc fc fc > [ 12.606249] > ================================================================ > = > > thanks, > -- Shuah