On Mon, Sep 24, 2018 at 10:37 PM Matthias Kaehlcke <[email protected]> wrote: > > Use the new API to get the BD address instead of reading it directly > from the device tree. > > Also remove an unncessary pair of braces in the same area of code. >
This looks nice! Reviewed-by: Andy Shevchenko <[email protected]> > Signed-off-by: Matthias Kaehlcke <[email protected]> > --- > Changes in v2: > - pass bdaddr_t instead of byte pointer + len > --- > drivers/bluetooth/btqcomsmd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c > index 7df3eed1ef5e..ff74d2c46991 100644 > --- a/drivers/bluetooth/btqcomsmd.c > +++ b/drivers/bluetooth/btqcomsmd.c > @@ -172,11 +172,9 @@ static int btqcomsmd_probe(struct platform_device *pdev) > /* The local-bd-address property is usually injected by the > * bootloader which has access to the allocated BD address. > */ > - if (!of_property_read_u8_array(pdev->dev.of_node, "local-bd-address", > - (u8 *)&btq->bdaddr, sizeof(bdaddr_t))) > { > + if (!device_get_bd_address(&pdev->dev, &btq->bdaddr)) > dev_info(&pdev->dev, "BD address %pMR retrieved from > device-tree", > &btq->bdaddr); > - } > > hdev = hci_alloc_dev(); > if (!hdev) > -- > 2.19.0.444.g18242da7ef-goog > -- With Best Regards, Andy Shevchenko
