[PATCH net-next 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init

[Gustavo A. R. Silva]

In case memory resources for *fw* were successfully allocated,
release them before return.

Addresses-Coverity-ID: 1473968 ("Resource leak")
Fixes: 00d70d8e0e78 ("net: phy: mscc: add support for VSC8574 PHY")
Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com>
---
 drivers/net/phy/mscc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c
index bff56c3..af9fb2d 100644
--- a/drivers/net/phy/mscc.c
+++ b/drivers/net/phy/mscc.c
@@ -1292,7 +1292,7 @@ static int vsc8574_config_pre_init(struct phy_device 
*phydev)
                                dev_err(dev,
                                        "%s: failed to assert reset of micro\n",
                                        __func__);
-                               return ret;
+                               goto release_fw;
                        }
                }
        } else {
@@ -1338,7 +1338,7 @@ static int vsc8574_config_pre_init(struct phy_device 
*phydev)
 
 out:
        phy_base_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_STANDARD);
-
+release_fw:
        release_firmware(fw);
 
        return ret;
-- 
2.7.4