Hi Gustavo, On Tue, Oct 09, 2018 at 09:38:33PM +0200, Gustavo A. R. Silva wrote: > Currently, the error handling for the call to function > phy_read_paged() doesn't work because *reg_val* is of > type u16 (16 bits, unsigned), which makes it impossible > for it to hold a value less than 0. >
Ah, rookie mistake! I should have run Coccinelle on the patches.
> Fix this by changing the type of variable *reg_val* to int.
>
> Addresses-Coverity-ID: 1473970 ("Unsigned compared against 0")
> Fixes: 6a0bfbbe20b0 ("net: phy: mscc: migrate to phy_select/restore_page
> functions")
Reviewed-by: Quentin Schulz <[email protected]>
Thanks!
Quentin
signature.asc
Description: PGP signature
