On Tue, 2018-10-23 at 20:54 +0200, Dominik Brodowski wrote:
> Fixes: 86d333a8cc7f ("cpufreq: intel_pstate: Add base_frequency
> attribute")
Thanks for the fix.> Cc: Srinivas Pandruvada <[email protected]> > Cc: Rafael J. Wysocki <[email protected]> > Cc: Len Brown <[email protected]> > Signed-off-by: Dominik Brodowski <[email protected]> > > diff --git a/drivers/cpufreq/intel_pstate.c > b/drivers/cpufreq/intel_pstate.c > index 49c0abf2d48f..50c5699970c5 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -390,11 +390,6 @@ static int intel_pstate_get_cppc_guranteed(int > cpu) > static void intel_pstate_set_itmt_prio(int cpu) > { > } > - > -static int intel_pstate_get_cppc_guranteed(int cpu) > -{ > - return -ENOTSUPP; > -} What is ACPI is defined but SCHED_MC_PRIO is not defined? Based on "select ACPI_CPPC_LIB if X86_64 && ACPI && SCHED_MC_PRIO" So the above is still required. correct? > #endif > > static void intel_pstate_init_acpi_perf_limits(struct cpufreq_policy > *policy) > @@ -490,6 +485,11 @@ static inline bool > intel_pstate_acpi_pm_profile_server(void) > { > return false; > } > + > +static int intel_pstate_get_cppc_guranteed(int cpu) > +{ > + return -ENOTSUPP; > +} > #endif > > static inline void update_turbo_state(void)
