Hi! > >> diff --git a/Documentation/leds/leds-class.txt > >> b/Documentation/leds/leds-class.txt > >> index 836cb16..e9009c4 100644 > >> --- a/Documentation/leds/leds-class.txt > >> +++ b/Documentation/leds/leds-class.txt > >> @@ -43,7 +43,7 @@ LED Device Naming > >> > >> Is currently of the form: > >> > >> -"devicename:colour:function" > >> +"colour:function" > >> > > > > I don't think we want to do it in all cases. > > > > So, on my cellphone seeing lp5523:green:led is indeed not useful. > > > > But on notebook with usb keyboard attached, you need to keep the > > devicename to be able to distinguish capslock on internal keyboard and > > capslock on first USB keyboard and capslock on second USB keyboard. > > > > Taking look at the list of functions, here's stuff like "hdd" and > > "hdderr". I assume the first means hdd activity... If we can do it, it > > would be nicest to have "sda:green:activity" and maybe > > "sda:red:error". For a raid array with 8 drives... > > > > For example I have a router running linux. It has 4 lan ports, with > > correspondings LED, and an wan led. > > > > Having "green:lan1" to "green:lan4" and "green:wan" plus > > "red:wanerror" would work, but I'd really preffer > > "eth0:green:link"... "adsl0:green:link", "adsl0:red:error". > > > > There are now phones with flashes on both main and selfie > > cameras. Again, knowing which device is which is important. As is > > knowing which display is controlled by particular backlight. > > It's overcomplicating the naming again. In every case you can tweak > the function name to eth0_link, eth1_link etc.
Well, but in such case it would be good to keep existing scheme.
My system looks like this:
input16::capslock tpacpi::bay_active tpacpi::standby
input16::numlock tpacpi::dock_active tpacpi::thinklight
input16::scrolllock tpacpi::dock_batt tpacpi::thinkvantage
input5::capslock tpacpi::dock_status1 tpacpi::unknown_led
input5::numlock tpacpi::dock_status2 tpacpi::unknown_led2
input5::scrolllock tpacpi:green:batt tpacpi::unknown_led3
I agree that we should get rid of "tpacpi:" part in some cases. But
it does not make sense to get rid of "input16:" part -- it tells you
if the LED is on USB or on built-in keyboard.
Ideally, tpacpi::thinklight would be input5::frontlight (as it is
frontlight for the keyboard).
Yes we should simplify, but it still needs to work in all cases.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
