On 21/11/2018 06:49, Anson Huang wrote: > Put return value checks of calling imx_init_from_nvmem_cells() > into one block to save one condition block for normal case. > > Signed-off-by: Anson Huang <anson.hu...@nxp.com>
Reviewed-by: Daniel Lezcano <daniel.lezc...@linaro.org> > --- > drivers/thermal/imx_thermal.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c > index c924396..bb6754a 100644 > --- a/drivers/thermal/imx_thermal.c > +++ b/drivers/thermal/imx_thermal.c > @@ -742,9 +742,10 @@ static int imx_thermal_probe(struct platform_device > *pdev) > > if (of_find_property(pdev->dev.of_node, "nvmem-cells", NULL)) { > ret = imx_init_from_nvmem_cells(pdev); > - if (ret == -EPROBE_DEFER) > - return ret; > if (ret) { > + if (ret == -EPROBE_DEFER) > + return ret; > + > dev_err(&pdev->dev, "failed to init from nvmem: %d\n", > ret); > return ret; > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog