Hi Chanwoo Choi,

Thank you for the review of the patch set.
I will add your suggestions in v2 and add 'Reviewed-by' for the last to 
patches.

On 11/22/18 4:09 AM, Chanwoo Choi wrote:
> Hi,
> 
> On 2018년 11월 22일 03:01, Lukasz Luba wrote:
>> Mark the state for devfreq device while entring suspend/resume process.
>>
>> The patch draws on Tobias Jakobi's work posted ~2 years ago, who tried to
>> solve issue with devfreq device's frequency during suspend/resume.
>> During the discussion on LKML some corner cases and comments appeared
>> related to the design. This patch address them keeping in mind suggestions
>> from Chanwoo Choi.
>>
>> Suggested-by: Tobias Jakobi <[email protected]>
>> Suggested-by: Chanwoo Choi <[email protected]>
>> Signed-off-by: Lukasz Luba <[email protected]>
>> ---
>>   arch/arm/boot/dts/exynos4210.dtsi | 2 ++
>>   arch/arm/boot/dts/exynos4412.dtsi | 2 ++
>>   2 files changed, 4 insertions(+)
> 
> Looks good to me.
> Reviewed-by: Chanwoo Choi <[email protected]>
> 
>>
>> diff --git a/arch/arm/boot/dts/exynos4210.dtsi 
>> b/arch/arm/boot/dts/exynos4210.dtsi
>> index b6091c2..4429b72 100644
>> --- a/arch/arm/boot/dts/exynos4210.dtsi
>> +++ b/arch/arm/boot/dts/exynos4210.dtsi
>> @@ -298,6 +298,7 @@
>>                      opp-400000000 {
>>                              opp-hz = /bits/ 64 <400000000>;
>>                              opp-microvolt = <1150000>;
>> +                            opp-suspend;
>>                      };
>>              };
>>   
>> @@ -367,6 +368,7 @@
>>                      };
>>                      opp-200000000 {
>>                              opp-hz = /bits/ 64 <200000000>;
>> +                            opp-suspend;
>>                      };
>>              };
>>      };
>> diff --git a/arch/arm/boot/dts/exynos4412.dtsi 
>> b/arch/arm/boot/dts/exynos4412.dtsi
>> index 51f72f0..908c0c4 100644
>> --- a/arch/arm/boot/dts/exynos4412.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412.dtsi
>> @@ -432,6 +432,7 @@
>>                      opp-400000000 {
>>                              opp-hz = /bits/ 64 <400000000>;
>>                              opp-microvolt = <1050000>;
>> +                            opp-suspend;
>>                      };
>>              };
>>   
>> @@ -520,6 +521,7 @@
>>                      opp-200000000 {
>>                              opp-hz = /bits/ 64 <200000000>;
>>                              opp-microvolt = <1000000>;
>> +                            opp-suspend;
>>                      };
>>              };
>>   
>>
> 
> 

Regards,
Lukasz Luba

Reply via email to