On Thu, Nov 22, 2018 at 03:10:57AM +0000, k...@linuxonhyperv.com wrote: > --- /dev/null > +++ b/arch/arm64/hyperv/hv_hvc.S > @@ -0,0 +1,54 @@ > +/* SPDX-License-Identifier: GPL-2.0 */
Using SPDX is good, but: > + > +/* > + * Microsoft Hyper-V hypervisor invocation routines > + * > + * Copyright (C) 2018, Microsoft, Inc. > + * > + * Author : Michael Kelley <mikel...@microsoft.com> > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License version 2 as published > + * by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or > + * NON INFRINGEMENT. See the GNU General Public License for more > + * details. No need for these two paragraphs at all. If you add them now, someone will just come along later and rip them out. Please don't include them in the first place. Not to mention the first paragraph doesn't make sense, think about "which" version 2 the FSF published (hint, there was 5 or 7 or so...) That's why we have one in the kernel tree for everyone to rely on. thanks, greg k-h
