On Thu, Nov 29, 2018 at 11:25:00PM +0000, Colin King wrote: > From: Colin Ian King <[email protected]> > > Don't populate the const array mode_name on the stack but instead > make it static. Makes the object code smaller by 41 bytes: > > Before: > text data bss dec hex filename > 7699 1872 0 9571 2563 drivers/watchdog/asm9260_wdt.o > > After: > text data bss dec hex filename > 7594 1936 0 9530 253a drivers/watchdog/asm9260_wdt.o > > (gcc version 8.2.0 x86_64) > > Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]> > --- > drivers/watchdog/asm9260_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/asm9260_wdt.c b/drivers/watchdog/asm9260_wdt.c > index 2cf56b459d84..9768e44ffeb8 100644 > --- a/drivers/watchdog/asm9260_wdt.c > +++ b/drivers/watchdog/asm9260_wdt.c > @@ -278,7 +278,7 @@ static int asm9260_wdt_probe(struct platform_device *pdev) > struct watchdog_device *wdd; > struct resource *res; > int ret; > - const char * const mode_name[] = { "hw", "sw", "debug", }; > + static const char * const mode_name[] = { "hw", "sw", "debug", }; > > priv = devm_kzalloc(&pdev->dev, sizeof(struct asm9260_wdt_priv), > GFP_KERNEL); > -- > 2.19.1 >
