On Sun, Dec 02, 2018 at 11:23:25PM -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_WM831X_I2C > drivers/mfd/Kconfig: bool "Wolfson Microelectronics WM831x/2x PMICs with > I2C" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_init was not in use by this code, the init ordering > remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > Cc: Lee Jones <[email protected]> > Cc: [email protected] > Signed-off-by: Paul Gortmaker <[email protected]> > --- > -static int wm831x_i2c_remove(struct i2c_client *i2c) > -{ > - struct wm831x *wm831x = i2c_get_clientdata(i2c); > - > - wm831x_device_exit(wm831x);
These patches remove the only callers of wm831x_device_exit, so I guess we should probably remove that function too? Thanks, Charles
