On Thu, Dec 06, 2018 at 12:47:46PM +0100, Linus Walleij wrote: > On Thu, Dec 6, 2018 at 11:34 AM Charles Keepax > <[email protected]> wrote: > > On Thu, Dec 06, 2018 at 09:58:30AM +0100, Linus Walleij wrote: > > > On Wed, Dec 5, 2018 at 4:33 PM Charles Keepax > > > <[email protected]> wrote: > > > > On Wed, Dec 05, 2018 at 03:42:06PM +0100, Linus Walleij wrote: > > > > > On Wed, Dec 5, 2018 at 2:43 PM Charles Keepax > > > > > <[email protected]> wrote: > > > > > > On Wed, Dec 05, 2018 at 01:47:12PM +0100, Linus Walleij wrote: > > You shouldn't really need to use unhinge, you can just use devm > > on the path that doesn't pass it to the core and not on the > > one that does. You just need to update the error case below it to > > use config->ena_gpiod rather than gpiod. > > Indeed I just think it will be confusing when people read the code. > > It's better consistency if its just devm_* and the we unhinge the > one we pass to the regulator core IMO. >
That's ok no objections from my if you prefer it that way. Thanks, Charles
