On Fri, Dec 21, 2018 at 11:24:52PM -0800, Stephen Boyd wrote: > A grep of the kernel shows that many drivers print an error message if > they fail to get the irq they're looking for. Furthermore, those drivers > all decide to print the device name, or not, and the irq they were > requesting, or not, etc. Let's consolidate all these error messages into > the API itself, allowing us to get rid of the error messages in each > driver. ... > +error: > + if (warn) > + dev_err(&dev->dev, "IRQ%d not found\n", num);
Please don't use the notation IRQn - this is normally used when referring to interrupt numbers (such as those seen in /proc/interrupts) rather than a per-device interrupt index. Grep for IRQ% in drivers/ for many examples. dev_err(&dev->dev, "IRQ index %u not found: %d\n", num, ret); would be better - note also the use of %u for unsigned integers. Using %d for them is IMHO sloppy coding. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
