On Sat, Jan 12, 2019 at 6:05 PM Jens Axboe <ax...@kernel.dk> wrote: > > On 1/12/19 6:29 PM, john.hubb...@gmail.com wrote: > > From: John Hubbard <jhubb...@nvidia.com> > > > > Commit 49e54187ae0b ("ata: libahci_platform: comply to PHY framework") uses > > the PHY_MODE_SATA, but that enum had not yet been added. This caused a > > build failure for me, with today's linux.git. > > > > Also, there is a potentially conflicting (mis-named) PHY_MODE_SATA, hiding > > in the Marvell Berlin SATA PHY driver. > > > > Fix the build by: > > > > 1) Renaming Marvell's defined value to a more scoped name, > > in order to avoid any potential conflicts: PHY_BERLIN_MODE_SATA. > > > > 2) Adding the missing enum, which was going to be added anyway as part > > of [1]. > > > > [1] > > https://lkml.kernel.org/r/20190108163124.6409-3-miquel.ray...@bootlin.com > > > > Fixes: 49e54187ae0b ("ata: libahci_platform: comply to PHY framework") > > Linus, this is probably a better option in terms of what should go in to > fix that commit.
I'm OK with this, but it does beg the question how the patch was tested before submitting, if it didn't build. Is there functional breakage behind it? I currently lack online hardware to test myself, unfortunately. -Olof