Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events

[Andi Kleen]

> +static bool perf_evsel__should_skip(struct perf_evsel *evsel)
> +{
> +     struct perf_event_attr *attr = &evsel->attr;
> +     struct perf_evsel *leader = evsel->leader;
> +
> +     return (leader != evsel) && !attr->freq && !attr->sample_freq;
> +}
> +
>  static int process_sample_event(struct perf_tool *tool,
>                               union perf_event *event,
>                               struct perf_sample *sample,
> @@ -1934,6 +1942,9 @@ static int process_sample_event(struct perf_tool *tool,
>       struct perf_script *scr = container_of(tool, struct perf_script, tool);
>       struct addr_location al;
>  
> +     if (perf_evsel__should_skip(evsel))
> +             return 0;

That just skips, but surely it has to be displayed somewhere?

-Andi