Hi Daniel On Mon, Feb 04, 2019 at 11:31:14AM +0100, Daniel Vetter wrote: > Noticed why wonder what vboxvideo is using the ->master_set/drop hooks > for. Can you improve the gammar a little, I find it hard to read.
> > Signed-off-by: Daniel Vetter <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: Fabio Rafael da Rosa <[email protected]> > Cc: Nicholas Mc Guire <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Hans de Goede <[email protected]> > --- > drivers/staging/vboxvideo/TODO | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/vboxvideo/TODO b/drivers/staging/vboxvideo/TODO > index 2e0f99c3f10c..2953e7f794fb 100644 > --- a/drivers/staging/vboxvideo/TODO > +++ b/drivers/staging/vboxvideo/TODO > @@ -1,5 +1,7 @@ > TODO: > -Get a full review from the drm-maintainers on dri-devel done on this driver > +-Drop all the logic around initial_mode_queried/master_set&_drop and > everything > +related to this. kms clients can handle hotplugs. > -Extend this TODO with the results of that review > > Please send any patches to Greg Kroah-Hartman <[email protected]>, The syntax around "master_set&_drop" could be better. I wondered if the "&" was some rst syntax. But anyway, despite grammar nit and syntax nit: Reviewed-by: Sam Ravnborg <[email protected]> Which bring me back to a question asked a week ago or so. What is missing before we can move vboxvideo out of staging/ Could we carry a few TODO items over in drm/ ar do we need a clean TODO? Sam
