> > > >> I'm still also suggesting to squash "fix maximum transfer size" into this > >> patch because it is really part of DMA-support enabling. > > > > Max transfer length limits apply to PIO also but for DMA its more needed to > > prevent crash. > > So had this as patch before DMA as its applicable for both DMA & PIO. > > Oh, so the packet_header size also shall be excluded for the PIO as well, > really? It looked to me that PIO doesn't have that restriction and we only > need to exclude the header size for DMA.. > > > We exchanged on this yesterday, so thought the reason you want to squash > > separate patch and include in this is due to max msg len limit and when > > moved into hw feature. > > If PIO limits are incorrect, then it's absolutely fine to do it in the > separate patch. I probably just misunderstood your point. > > > Sorry should have verified before sending. Please confirm if I leave max > > transfer as separate patch or add to this DMA support. Will update along > > with dma buf size fix. > > > > But max transfer limit applied to PIO also and that’s why added it before > > DMA patch to show its dependency > > > > And then you need to explicitly tell in the commit message that PIO limits > are incorrect. Commit message says Tegra I2C max limit per packets transfer meaning that’s interface transfer limit so applies to both PIO & DMA. Will add explicitly indicating applicable for both PIO & DMA to be more clear
> > It also probably worth to add a stable-tag to the commit message to request > backporting of the limits-fixing patch to the stable kernels: > > Cc: [email protected] > Sorry I am new to upstream submissions. By adding stable-tag to commit message, do you mean explicitly mentioning this patch applicable to old kernel and adding in patch CC [email protected]?
