On Fri, Feb 15, 2019 at 9:01 AM Kees Cook <[email protected]> wrote: > > The !*first will never hit here (since it's been checked to be either > ' ' or '\t', and if first == last it's whitespace all the way, so we > could just return true here to bail out early (there's no interpreter > at all, so we want to -ENOEXEC still).
Correct.
You do need the !*first test, but it needs to be after the loop
(because the next loop skips over the first non-space thing we found).
Linus
