On 21/02/2019 22:43, David Abdurachmanov wrote: > On Thu, Feb 21, 2019 at 9:48 PM Daniel Lezcano > <[email protected]> wrote: >> >> On 21/02/2019 17:06, David Abdurachmanov wrote: >>> Resending to incl. a proper mailing list and maintainers (not suggested >>> by scripts/get_maintainer.pl) >>> >>> This is only used on arm and arm64 platforms. Other timers also seem >>> to depend on (ARM || ARM64). >>> >>> After I moved Fedora/RISCV kernel to 5.0.0-0.rc2 it keeps asking me to >>> add CONFIG_ARM_TIMER_SP804=n to my config. This patch resolved the issue. >>> >>> Signed-off-by: David Abdurachmanov <[email protected]> >>> --- >>> drivers/clocksource/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >>> index a9e26f6a81a1..7593d80e1c88 100644 >>> --- a/drivers/clocksource/Kconfig >>> +++ b/drivers/clocksource/Kconfig >>> @@ -369,7 +369,7 @@ config ARM_GLOBAL_TIMER >>> >>> config ARM_TIMER_SP804 >>> bool "Support for Dual Timer SP804 module" >>> - depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP >>> + depends on (ARM || ARM64) && GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP >> >> What about adding the COMPILE_TEST option: >> >> bool "Support for Dual Timer SP804 module" if COMPILE_TEST >> >> but not add the ARM || ARM64 dependency ? >> > > That would work, but is that consistent with other timers?
Yes, I'm making all timers to converge to COMPILE_TEST option. > Looks like a number of them have depends on + COMPILE_TEST. > > Some examples: > > config ROCKCHIP_TIMER > bool "Rockchip timer driver" if COMPILE_TEST > depends on ARM || ARM64 > > config ARMADA_370_XP_TIMER > bool "Armada 370 and XP timer driver" if COMPILE_TEST > depends on ARM > > config ORION_TIMER > bool "Orion timer driver" if COMPILE_TEST > depends on ARM > > config ARM_GLOBAL_TIMER > bool "Support for the ARM global timer" if COMPILE_TEST > select TIMER_OF if OF > depends on ARM > > config CLKSRC_EXYNOS_MCT > bool "Exynos multi core timer driver" if COMPILE_TEST > depends on ARM || ARM64 > > david > >>> select CLKSRC_MMIO >>> select TIMER_OF if OF >>> >>> >> >> >> -- >> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs >> >> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | >> <http://twitter.com/#!/linaroorg> Twitter | >> <http://www.linaro.org/linaro-blog/> Blog >> -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
