On Tue, Feb 26, 2019 at 01:55:37PM +0530, Sameer Pujar wrote: > The requirement for this came while adding runtime PM support for HDA > driver. There were concerns about driver explicitly handling !PM case. > In general, drivers need to handle !PM case with work arounds for > managing clocks and power explicitly, which is not really necessary > when PM support on tegra is in good shape. In fact ARM 64-bit Tegra > platforms enforce PM support and there is no reason why this cannot be > done for 32-bit. > > More details with regards to above can be found in following patch, > http://patchwork.ozlabs.org/patch/1036645/ > > This patch selects PM unconditionally and drivers can rely on runtime > PM framework for clock and power management.
What if the drivers are re-used on another SoC IP? Doesn't this lead to unexpected failures? If you want to do this, maybe also make those drivers depend on PM as well? > Signed-off-by: Sameer Pujar <spu...@nvidia.com> > Reviewed-by: Thierry Reding <tred...@nvidia.com> > Reviewed-by: Jonathan Hunter <jonath...@nvidia.com> > --- > arch/arm/mach-tegra/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > index 7f3b83e..51a8fa3 100644 > --- a/arch/arm/mach-tegra/Kconfig > +++ b/arch/arm/mach-tegra/Kconfig > @@ -10,6 +10,7 @@ menuconfig ARCH_TEGRA > select HAVE_ARM_SCU if SMP > select HAVE_ARM_TWD if SMP > select PINCTRL > + select PM > select PM_OPP > select ARCH_HAS_RESET_CONTROLLER > select RESET_CONTROLLER > -- > 2.7.4 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up