Re: [PATCH net-next 14/15] net: mvpp2: set the XPCS and MPCS in reset when not used

[David Miller]

From: Antoine Tenart <antoine.ten...@bootlin.com>
Date: Thu, 28 Feb 2019 14:21:27 +0100

> +static void mvpp22_pcs_reset(struct mvpp2_port *port)
> +{
> +     struct mvpp2 *priv = port->priv;
> +     void __iomem *mpcs = priv->iface_base + MVPP22_MPCS_BASE(port->gop_id);
> +     void __iomem *xpcs = priv->iface_base + MVPP22_XPCS_BASE(port->gop_id);
> +     u32 val;

Reverse christmas tree please.

 ...
> +static void mvpp22_pcs_unreset(struct mvpp2_port *port)
> +{
> +     struct mvpp2 *priv = port->priv;
> +     void __iomem *mpcs = priv->iface_base + MVPP22_MPCS_BASE(port->gop_id);
> +     void __iomem *xpcs = priv->iface_base + MVPP22_XPCS_BASE(port->gop_id);
> +     u32 val;

Likewise.