On Tue, 2019-03-19 at 09:29 -0700, Bart Van Assche wrote:
> On Mon, 2019-03-18 at 16:57 +0800, Yuyang Du wrote:
> > - if (ret < 0) {
> > + if (unlikely(ret < 0)) {
> > print_bfs_bug(ret);
> > return 0;
> > }
> > - if (ret == 1)
> > + else if (ret == 1)
> > return ret;
>
> Have you verified this patch series with checkpatch? Checkpatch should have
> reported that you are changing code that conforms to the coding style into
> code that does not conform to the kernel coding style. Checkpatch should have
> reported the following:
>
> "else is not generally useful after a break or return"
checkpatch just ain't that smart.
You're welcome to try to improve it.
