On Fri, Mar 29, 2019 at 10:34 AM Paul Walmsley <paul.walms...@sifive.com> wrote: > > > On Thu, 28 Mar 2019, Anup Patel wrote: > > > Signed-off-by: Gary Guo <g...@garyguo.net> > > Signed-off-by: Anup Patel <anup.pa...@wdc.com> > > --- > > Changes since v1: > > - We adapt good aspects from Gary Guo's ASID allocator implementation > > and provide due credit to him by adding his SoB. > > This isn't the right way to use Signed-off-by: lines in the kernel. See > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/5.Posting.rst#n213 > > and > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n418 > > The only people who should be listed in Signed-off-by: lines are patch > authors. > > If your intention is to give Gary credit for changes in your patch, > describe what ideas or code snippets you've taken in the patch description > itself, above your Signed-off-by: lines so they would be included in the > git commit description should your patch be merged.
Thanks for clarifying... Under "Changes since v1" I have clarified what suggestions I have taken from Gray. Gray insist that I use "Co-developed-by:" so I have posted v3 with "Co-developed-by:". Honestly, I don't mind "Signed-off-by: " or "Co-developed-by:" as long as I am acknowledging other person's efforts. Regards, Anup
