On Mon, Apr 8, 2019 at 8:05 AM Enric Balletbo i Serra <[email protected]> wrote: > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Greg Kroah-Hartman <[email protected]> > Signed-off-by: Enric Balletbo i Serra <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]> > --- > > drivers/platform/chrome/cros_ec_debugfs.c | 35 ++++------------------- > 1 file changed, 6 insertions(+), 29 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_debugfs.c > b/drivers/platform/chrome/cros_ec_debugfs.c > index f0de1991b688..a712508e4646 100644 > --- a/drivers/platform/chrome/cros_ec_debugfs.c > +++ b/drivers/platform/chrome/cros_ec_debugfs.c > @@ -337,12 +337,8 @@ static int cros_ec_create_console_log(struct > cros_ec_debugfs *debug_info) > mutex_init(&debug_info->log_mutex); > init_waitqueue_head(&debug_info->log_wq); > > - if (!debugfs_create_file("console_log", > - S_IFREG | 0444, > - debug_info->dir, > - debug_info, > - &cros_ec_console_log_fops)) > - return -ENOMEM; > + debugfs_create_file("console_log", S_IFREG | 0444, debug_info->dir, > + debug_info, &cros_ec_console_log_fops); > > INIT_DELAYED_WORK(&debug_info->log_poll_work, > cros_ec_console_log_work); > @@ -390,13 +386,8 @@ static int cros_ec_create_panicinfo(struct > cros_ec_debugfs *debug_info) > debug_info->panicinfo_blob.data = msg->data; > debug_info->panicinfo_blob.size = ret; > > - if (!debugfs_create_blob("panicinfo", > - S_IFREG | 0444, > - debug_info->dir, > - &debug_info->panicinfo_blob)) { > - ret = -ENOMEM; > - goto free; > - } > + debugfs_create_blob("panicinfo", S_IFREG | 0444, debug_info->dir, > + &debug_info->panicinfo_blob); > > return 0; > > @@ -405,15 +396,6 @@ static int cros_ec_create_panicinfo(struct > cros_ec_debugfs *debug_info) > return ret; > } > > -static int cros_ec_create_pdinfo(struct cros_ec_debugfs *debug_info) > -{ > - if (!debugfs_create_file("pdinfo", 0444, debug_info->dir, debug_info, > - &cros_ec_pdinfo_fops)) > - return -ENOMEM; > - > - return 0; > -} > - > static int cros_ec_debugfs_probe(struct platform_device *pd) > { > struct cros_ec_dev *ec = dev_get_drvdata(pd->dev.parent); > @@ -428,8 +410,6 @@ static int cros_ec_debugfs_probe(struct platform_device > *pd) > > debug_info->ec = ec; > debug_info->dir = debugfs_create_dir(name, NULL); > - if (!debug_info->dir) > - return -ENOMEM; > > ret = cros_ec_create_panicinfo(debug_info); > if (ret) > @@ -439,9 +419,8 @@ static int cros_ec_debugfs_probe(struct platform_device > *pd) > if (ret) > goto remove_debugfs; > > - ret = cros_ec_create_pdinfo(debug_info); > - if (ret) > - goto remove_log; > + debugfs_create_file("pdinfo", 0444, debug_info->dir, debug_info, > + &cros_ec_pdinfo_fops); > > ec->debug_info = debug_info; > > @@ -449,8 +428,6 @@ static int cros_ec_debugfs_probe(struct platform_device > *pd) > > return 0; > > -remove_log: > - cros_ec_cleanup_console_log(debug_info); > remove_debugfs: > debugfs_remove_recursive(debug_info->dir); > return ret; > -- > 2.20.1 >
