On 05/04/2019 19:51, Andrey Smirnov wrote: > On Wed, Apr 3, 2019 at 8:21 PM Daniel Lezcano <[email protected]> > wrote: >> >> On 01/04/2019 06:14, Andrey Smirnov wrote: >>> This driver is meant to be used with Device Tree and there's no >>> use-case where device's DT node is going to be NULL. Remove code >>> protecting against that. >> >> May be elaborate why is never going to be NULL? >> > > Hmm, I am not sure what can be elaborated further than what's already > there. The driver is written to be instantiated via DT and there's no > code that tries to do that via board code or anything like that. I am > guessing you maybe read the description differently. Can you help me > by giving an example of what you think needs clarifying?
May be just say if the probe function is called, the dev.of_node is guarantee to be filled by the underlying framework because the compatible string was found so the check is pointless. Anyway, it is a detail. >>> Signed-off-by: Andrey Smirnov <[email protected]> >>> Cc: Chris Healy <[email protected]> >>> Cc: Lucas Stach <[email protected]> >>> Cc: Zhang Rui <[email protected]> >>> Cc: Eduardo Valentin <[email protected]> >>> Cc: Daniel Lezcano <[email protected]> >>> Cc: Angus Ainslie (Purism) <[email protected]> >>> Cc: [email protected] >>> Cc: [email protected] >>> Cc: [email protected] >> >> Acked-by: Daniel Lezcano <[email protected]> >> >>> --- >>> drivers/thermal/qoriq_thermal.c | 5 ----- >>> 1 file changed, 5 deletions(-) >>> >>> diff --git a/drivers/thermal/qoriq_thermal.c >>> b/drivers/thermal/qoriq_thermal.c >>> index 3b5f5b3fb1bc..7b364933bfb1 100644 >>> --- a/drivers/thermal/qoriq_thermal.c >>> +++ b/drivers/thermal/qoriq_thermal.c >>> @@ -193,11 +193,6 @@ static int qoriq_tmu_probe(struct platform_device >>> *pdev) >>> struct qoriq_tmu_data *data; >>> struct device_node *np = pdev->dev.of_node; >>> >>> - if (!np) { >>> - dev_err(&pdev->dev, "Device OF-Node is NULL"); >>> - return -ENODEV; >>> - } >>> - >>> data = devm_kzalloc(&pdev->dev, sizeof(struct qoriq_tmu_data), >>> GFP_KERNEL); >>> if (!data) >>> >> >> >> -- >> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs >> >> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | >> <http://twitter.com/#!/linaroorg> Twitter | >> <http://www.linaro.org/linaro-blog/> Blog >> -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
