On Sun, 14 Apr 2019, Markus Elfring wrote:

> > @@ -250,8 +250,10 @@ static int __init omapdss_init_of(void)
> >     if (!node)
> >             return 0;
> >
> > -   if (!of_device_is_available(node))
> > +   if (!of_device_is_available(node)) {
> > +           of_node_put(node);
> >             return 0;
> > +   }
> >
> >     pdev = of_find_device_by_node(node);
>
> Is there a need to put the node also in subsequent if branches
> for complete exception handling in this function implementation?

Yes, it looks like this is indeed missing.  I will try to send a better
patch when time permits.

julia

Reply via email to